Supply offset changes on sdk fork #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout GenesisSupplyOffsets
ValarDragon
approved these changes
Aug 16, 2022
|
@ValarDragon I saw you merged this. We will probably need to update the dependency again once osmosis-labs/cosmos-sdk#312 is merged. That should be really quick, just wanted to point it out here. |
|
Yup! Wanted to just unblock other prs due to the api change tho |
|
@ValarDragon merged the change and added a new PR (#2421) with the correct hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2307
What is the purpose of the change
The sdk fork is using GenesisSupplyOffsets in the banktypes.NewGenesisState() constructor. This is incompatible with the ibc-go testing package which expects the new signature (https://github.com/cosmos/ibc-go/tree/main/testing).
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage. The existing tests pass.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (no)